refact: resolve ambigous variable name #1253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR |
|
/run-example-tests |
|
Please view the results of the PR Build Here |
|
Hey, @gunar could you give me more context for why you want this change? 🙂 |
gunar
commented
Sep 15, 2022
Comment on lines
+22
to
+23
| user = pulumi_gcp.sql.User( | ||
| "user", |
There was a problem hiding this comment.
It's a single user so no point in being plural.y
| name=config.require("db-name"), | ||
| instance=cloud_sql_instance.name, | ||
| password=config.require_secret("db-password"), | ||
| ) | ||
|
|
||
| sql_instance_url = Output.concat( | ||
| "postgres://", | ||
| config.require("db-name"), | ||
| user.name, |
There was a problem hiding this comment.
Even though config.require("db-name") === user.name, it'd be best to reference user.name instead so the chain of dependencies is clear to both the reader and to the Pulumi engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.