Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post on terraform convert improvements #13777
base: master
Are you sure you want to change the base?
Blog post on terraform convert improvements #13777
Changes from 1 commit
f91b70f
cec090c
8dae809
a0dcd9a
8591a1f
c94166b
1cc431e
7b54a73
9158c40
db47a9a
b468dbb
4a5ab23
55d1859
416ccd3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"anxious" -> "eager" (improper word use: "anxious" has a negative connotation, e.g. that you're worried or concerned about something, while "eager" has a positive connotation indicating excitement and an expectation of a good experience)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this not work for yaml/dotnet/java?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does but I havent gotten around to testing each of those (there are enough issues from various subtleties in the ones built into the repo). Figured I'd wait until it was out of draft stage and folks had a look at it, but I'm going to test/add them after that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"off to the races" -> "ready to deploy" (avoid idioms that readers may not understand. imagine someone reading this and interpreting it literally. it would be very confusing.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"i've thrown together" -> "we've provided" ("i" vs "we": this is a switch from the plural first person to the singular first person, which is inconsistent with the rest of the article. also "thrown together" is a another case of a idiom that might throw off a reader. even if they understand the idiom, it implies low quality and a lack of trustworthiness. better to use a more neutral term like "provided")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"a simple Terraform project" -> "a Terraform project" (words like "simple" can be an emotional trigger. this example may not seem simple to new/inexperienced users and could make them feel embarrassed/overwhlemed if they don't understand something that is supposed to be "simple". it's better to avoid qualifier terms that might have an unintended opposite effect on the reader)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide links to GCE/PlanetScale for those unfamiliar with them to explore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"pulumi" -> "Pulumi" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"... registry, and the ..." -> "... registry. The ..." (run on sentence)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Planetscale" -> "PlanetScale" (use correct capitalization for product name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The project will specify using a specific version of" -> "The project will use a specific version of" (redundant use of "specify" conjugations)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"main.tf" -> "
main.tf
" (use code formatting for filenames)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"terraform" -> "Terraform" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"... or commited configuration files." -> ".. or configuration files committed to a code repository." (ambiguous use of the term "committed". also misspelled)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"db_password" -> "
db_password
" (use code formatting for variable names)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"... store these types of secrets (and any other configuration!) and access them directly from ... " -> "... store and access these types of secrets and configuration values directly from ..." (simplify grammar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This alone works if you run ..." -> "This is all you need to run ..." (simplify grammar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"will really deploy" -> "will deploy" (redundant use of conjugations of "real")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tfvars" -> "
.tfvars
" (use code formatting for filenames. also, provide a link to Terraform documentation for these files for unfamiliar users)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"environmental variables" -> "environment variables" (this is a specific technical term not general language term, so we need to use the exact wording)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"command line" -> "command line parameters" (grammar: command line is an adjective here and needs a noun)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tfvars" -> "
.tfvars
" (use code formatting for filenames)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"index.ts" & "main.tf" -> "
index.ts
" & "main.tf
" (use code formatting for filenames)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"typescript" -> "TypeScript" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"sdks directory" -> either "SDKs directory" (if we're talking about a type of directory) or "
sdks
directory if this is a specific directory name)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"is output" -> "is outputted" (grammar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"node" -> "Node.js" (use proper noun)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"package.json, node_modules, tsconfig.json" -> "
package.json
,node_modules
,tsconfig.json
" (use code formatting for filenames)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"__main__.py" -> "
__main__.py
" (use code formatting for filenames)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"main.tf" -> "
main.tf
" (use code formatting for filenames)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"python" -> "Python" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"sdks directory" -> either "SDKs directory" (if we're talking about a type of directory) or "
sdks
directory if this is a specific directory name)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"is output" -> "is outputted" (grammar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"python" -> "Python" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"(eg ... )" -> "such as ..." (consistent language with previous example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"requirments.txt, pyproject.toml" -> "
requirements.txt
,pyproject.toml
" (use code formatting for filenames, also "requirements" is misspelled)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Python specific" -> "Python-specific" (grammar: should be hyphenated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"python" -> "Python" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"syntax like so" -> "syntax, like so" (grammar: use comma to separate phrases)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"main.go, our equivalent to main.tf" -> "
main.go
, our equivalent tomain.tf
" (use code formatting for filenames)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"golang" -> "Go" or "Golang" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"sdks directory" -> either "SDKs directory" (if we're talking about a type of directory) or "
sdks
directory if this is a specific directory name)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"is output" -> "is outputted" (grammar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"golang" -> "Go" or "Golang" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"go.mod, go.sum" -> "
go.mod
,go.sum
" (use code formatting for filenames)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Go specific" -> "Go-specific" (grammar: hyphenate)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"go" -> "Go" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"go" -> "Go" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"like GCP project" -> "like the GCP project" (grammar: use definite article)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"planetscale" -> "PlanetScale" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"it's" -> "its" (grammar: use correct possessive form)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"provider configuration (see cleanup) and not actual code." -> "provider configuration and not actual code (see cleanup)." (grammar: parenthetical interjection should not break up the phrase)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"simply run" -> "run" (grammar: incorrect word use)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"project unfortunately won't run right away." -> "project won't run as it is." (simplify grammar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"create our stack configuration" -> "create a stack configuration" (grammar: word use)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Planetscale" -> "PlanetScale" (use proper capitalization for product names)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"(for now)" ... if it exists, link "for now" to a GH issue or other public documentation about the planned changes that would make this manual step unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Places" -> "Placeholders" (grammar: word use)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"pulumi" -> "Pulumi" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"cleaned up some" -> "cleaned up" (grammar: remove redundant word)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"terraform" -> "Terraform" (capitalize proper nouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"a simple workaround" -> "a workaround" (remove "simple")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"dynamically typed, when" -> "dynamically typed. When" (grammar, break up run-on sentence)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"type safe" -> "type-safe" (hyphenate to use as adjective)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"still needs to" -> "needs to" (simplify grammar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"typescript" -> "TypeScript" (capitalize proper nouns)