🌿 add missing top-level values: to various ESC reference examples
#13695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some ESC reference examples were missing the top-level `values:` key. This could confuse the reader into thinking `values:` is not required but where in fact it's required. As ESC doesn't complain about such syntax it's even harder to identify the problem. This PR adds those missing top-level `values:` for the relevant ESC reference examples and makes indentation consistent. Additionally, a few trailing spaces have been removed.
aureq
added
impact/no-changelog-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some ESC reference examples were missing the top-level
values:key. This could confuse the reader into thinkingvalues:is not required but where in fact it's required. As ESC doesn't complain about such syntax it's even harder to identify the problem.This PR adds those missing top-level
values:for the relevant ESC reference examples and makes indentation consistent.Additionally, a few trailing spaces have been removed.