-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post for the Command provider GA #12076
Conversation
40e843d
to
98ccc03
Compare
Your site preview for commit 98ccc03 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12076-98ccc035.s3-website.us-west-2.amazonaws.com. |
7be04c8
to
4a9f5aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions - but overall looks great - looking forward to the launch~
|
||
Here’s a simple example of running commands when another resource changes. In this case, a file is created when a pet name is created or changed, and the file is deleted when the pet name is removed. In a real-world scenario, the command could register/deregister the resource with an external API. | ||
|
||
{{< chooser language "typescript,go,python,csharp,yaml" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could use a more "exciting" example. A few things:
- Could we make one of the examples at https://www.pulumi.com/registry/packages/command/ simple enough to include here?
- I think using
RandomPet
may be distracting - it's not a "normal" infrastructure thing, and not really core to what we're trying to talk about here. - If none of the existing examples above work, would still be good to describe a "real" scenario here of some sort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced with a working Lambda example
6ac1d82
to
acaf1e8
Compare
2894b31
to
2dde5a7
Compare
Your site preview for commit 2dde5a7 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12076-2dde5a77.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 0666e07 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12076-0666e076.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple nits on wording, but overall this looks pretty good to me.
0666e07
to
65b71bb
Compare
Your site preview for commit 65b71bb is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12076-65b71bbc.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 00cb3be is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12076-00cb3be2.s3-website.us-west-2.amazonaws.com. |
Co-authored-by: Ian Wahbe <[email protected]>
Co-authored-by: Luke Hoban <[email protected]>
00cb3be
to
01b0679
Compare
Your site preview for commit 01b0679 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12076-01b06799.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 31de30c is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-12076-31de30c2.s3-website.us-west-2.amazonaws.com. |
Proposed changes
The Command provider is about to have its v1 released, marking GA.