Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary signing #1296

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Fix binary signing #1296

merged 2 commits into from
Jan 16, 2025

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Jan 16, 2025

Fixes binary signing for Node binaries and darwin-arm64.

@t0yv0 t0yv0 requested a review from a team January 16, 2025 14:25
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No harm in having the extra step even though unused. We could feature-flag this to only nodejs based providers in the future.

@t0yv0
Copy link
Member Author

t0yv0 commented Jan 16, 2025

It seeems to be very quick (likely uses GHA cache or some such), perhaps no harm in leaving in.

@t0yv0 t0yv0 enabled auto-merge January 16, 2025 14:28
@t0yv0 t0yv0 added this pull request to the merge queue Jan 16, 2025
Merged via the queue into master with commit 730b8c1 Jan 16, 2025
6 checks passed
@t0yv0 t0yv0 deleted the t0yv0/fix-binary-signing branch January 16, 2025 15:17
t0yv0 added a commit to pulumi/pulumi-awsx that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants