-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dugite tests #4
Conversation
Also a note, I'd recommend we review and merge #3 prior to checking this one out, since without those changes in core this PR is rather cumbersome to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a "request changes" review, but I like what I see and it gives me an idea for how to do this reproducibly with no issues. Thank you for getting this far with it this quickly!
@DeeDeeG And done, what do we think? Appreciate you noticing how this would bite us later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-it('tests dugite functionality')
- ✅
All tests coming back positive! (😄)
Thanks again for this! Feels very thorough to help reassure the dugite bump is going to go smoothly!
Thanks for the approval and your consistent reviews! But of course, feels good to be able to look at some passing specs and have fully confidence! Lets get it merged, then get the dugite bump updated |
This PR builds off of #3 as the changes were easier to implement and test once that was done.
This PR adds some testing of functions that actually use
dugite
. This is done so that we can be sure changes like #2 are not breaking anything, and we know they work accordingly.