Setup Tests and Modernize #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeeDeeG
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
This is neat!
Good to have the tests automatically running. (Not that there are very many tests to run, apparently!)
And the changes to package.json look good.
Thanks for doing this!
P.S. we should be able to test on newer than NodeJS 16 if we switch superstring to the copy at pulsar-edit/superstring repo.
The fact that this package depends on Atom's outdated superstring, and not pulsar-edit's copy that can build on Node newer than 16, is also affecting github package, which depends on whats-my-line and therefore indirectly on Atom's outdated copy of superstring...
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GitHub Actions based testing to this repository, as well as updates some of the information within the
package.jsonto be up to date and reflect the package's current status.