Candidate for migration #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions
We're about to commit it as regular files, so we first we need to get rid of the submodule.
This replaces what used to be a *submodule* of the win-iconv repo. Using git subtree preserves revision history, author info (including blame view), and so on. win-iconv is a very small repo, it's public domain, and it has few revisions. So, I think it's worth it to do all that, for giving proper attribution of author info, if for no other reason. Not using a submodule is more compatible with newer npm (npm 7.x+), and apparently with Yarn (v1.x?) as well. It's overall less complicated for end users of the superstring package/repo. --- Add 'vendor/win-iconv/' from commit '9f98392dfecadffd62572e73e9aba878e03496c4' git-subtree-dir: vendor/win-iconv git-subtree-mainline: 5b2f39d git-subtree-split: 9f98392
Node 14 is pretty old by now. Node 14 latest was Node v14.21.3, which came with npm v6.14.8, which came with node-gyp v5.1.1. node-gyp v5.1.1 doesn't support Visual Studio 2022, which is the most recent version and is included in the windows-latest GitHub-hosted runner for GitHub Actions. Using the windows-2019 GitHub-hosted runner for Node 14 on Windows should work, since old node-gyp v5.1.1 should work with Visual Studio 2019... Hopefully.
I don't know anything about C or C++, other than this fixes the compilation error on g++ 13. Tested in an Ubuntu 23.10 Docker container.
The quotation marks seem to be intepreted literally, breaking caching, since a dir named (literally, with quotes in the name) 'node_modules' doesn't exist? (Either that, or the cache actions or its glob dependency are just super broken.)
This ensures compatibility with most versions of node-gyp. There is a fix for Python 3.12 compatibility in node-gyp 10, but older versions of npm come with older node-gyp, so here we are.
For compatibility with old node-gyp, which is shipped with old npm, which is shipped with Node 14. Very old node-gyp isn't compatible with Python 3.11+. Install Python 3.10 instead.
* Remove scripts we don't need. * Report progress better on fetching/compiling `libiconv`. * Preserve the license and README from `libiconv`.
Merged
|
Closing in favor of #15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch starts with the SHA that matches what's in NPM, then adds all commits related to
win-iconvinto thevendordirectory instead of a submodule (soyarnwill do the right thing when installing from GitHub).