(Test) Fix install name _and_ encoding name conversion issue #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to match the version that `superstring` expects. This is copied directly from what Homebrew installs into `$(brew --prefix)/opt/libiconv`, except that the install name has been changed on `libiconv.2.dylib` to `libiconv.2.dylib`. (When it's installed from Homebrew, its macOS library “install name” matches its original path, so that's where macOS looks for it. As part of the build, we rename the library with `install_name_tool` so that it can be resolved relative to the location of `superstring.node`. This can probably be simplified, but first let's see if it'll work.
…because we need a version built for the current machine's architecture. (If our current approach doesn't work, we could vendorize two different copies — one for each architecture.)
…by grabbing it from Homebrew or from a path specified by the user in an environment variable.
…by adding an alternate strategy that we can adopt if we ever need to. Also copy over `libiconv`’s README and license file.
…saving the C++ code from receiving a Node-style encoding name that it doesn’t recognize.
…just to see if they're the cause of the editor test regressions in Pulsar.
|
Nah, this ain't it. |
|
Actually, I'll keep this around for a few more minutes. |
|
Closing in favor of #15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pulsar editor tests are failing in a way that confuses me. Most tests that modify the buffer seem to fail with
and, as luck would have it, I've got an open PR (#9) that fixes at least once cause of this.
This PR has all the changes from both #9 and #11; I'm opening it so that I can see if the changes from #9 fix the failing editor tests.