Debugging when a package service is incorrect #995
Conversation
This PR is basically to add some debugging info for providers and consumers. Currently, when a package registers as a service provider or a service consumer, and doesn't actually implements the right interface (a function, basically) the package loader silently ignores it. This commit adds a warning to console so that we know a package did the wrong thing.
There was a problem hiding this comment.
I'm not very familiar with services/providers/consumers, so if you want to wait for another reviewer that would make sense, but this implementation looks extremely simple and low-stakes, just adding two console.warn()s.
I'm not super familiar with the surrounding code to be sure we will have a this.name, name, version and methodName vars defined, but other than that I see no reason why this shouldn't work...
👍 LGTM
|
Should I merge in the macOS CI fix to this branch and re-run CI to see if it passes? Or just go ahead and merge this one as-is? I think it's very nearly impossible for this to cause errors unless it so happens to try and access a var or property that's not defined. Then again, I doubt that this code path is exercised in our existing specs either. |
|
@DeeDeeG There's no harm in doing so, but I don't think it's needed. With both our approvals I think we are good to merge |
This PR is basically to add some debugging info for providers and consumers. Currently, when a package registers as a service provider or a service consumer, and doesn't actually implements the right interface (a function, basically) the package loader silently ignores it. This commit adds a warning to console so that we know a package did the wrong thing.