[tree-sitter] Fix proliferation of extra injection layers #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esults When determining the possible breadth of injection layers that could be affected by a buffer change, I assumed that `MarkerLayer#findMarkers` would return results such that I could take the first result's start and the last result's end and end up with a range that containd all the results. pulsar-edit#756 proved that not to be true, at least in the case of Clojure — the effect of which is that lots of injection layers were getting ignored during the step where we decide whether to reuse existing layers or create new ones. That led to an ever-increasing number of injection layers being created. Instead, we need to find the minimum and maximum points in the set and use that as the range.
5 tasks
5 tasks
savetheclocktower
changed the title
|
Converting this to a single-issue PR so we can get it reviewed sooner. |
mauricioszabo
approved these changes
Oct 23, 2023
confused-Techie
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…starting with a big important fix for #756.