[core] Cleanup Unused Deps

[confused-Techie]

While investigating our dependencies I've noticed there are a few that don't seem to be used anywhere, that we should be fine to go ahead and remove.

• functional-red-black-tree: This seems to have been introduced prior to being entirely transpiled over to ./src/rb-tree.js. Meaning it's never actually been required into the project.
• property-accessors: Seems to have been removed back in 2015 via 69833af although for some reason still appears in the repo. I can't find any reference to it anywhere, and as it's a mixin, I think we should be safe to remove.
• glob: Originally introduced via fa90851 when adding benchmarking functionality to Atom, but since then benchmarking mode has been totally removed from Pulsar, and this file is not required anywhere else in the codebase.

So as long as tests all pass, we should be good to remove these dependencies as they are otherwise useless.

[DeeDeeG]

property-accessors: Seems to have been removed back in 2015 via 69833af although for some reason still appears in the repo. I can't find any reference to it anywhere, and as it's a mixin, I think we should be safe to remove.

"Somehow, property-accessors returned."

Memes aside, this description made me suspect a weird artifact of merge conflict resolution -- someone skims the changes and doesn't notice one line of package.json that they're accidentally re-introducing when incorrectly resolving the merge conflict.

I did a git bisect to track down where this might have happened. And... c148df11c9cbc19ef27412e858ddcebf4dd8e737.

So yeah, looks like an oversight during a merge.

[confused-Techie]

@DeeDeeG Thanks for tracking that down! I was a little worried when I was unable to find it, but that makes total sense. The commit you've linked was just the next day, so seems super probably they just had an older version checked out when making those changes, and that one modification got missed.

Glad to know that we can in fact remove this one then

[DeeDeeG]

I looked around (especially with git grep [package name here]) and couldn't find any obvious uses of these packages as top-level dependencies in the same context as the main package.json.

(Some packages have their own indirect dependencies on other copies of glob or property-accessors, but those shouldn't be overlapping with or related to this stuff.)

Seems legit.

EDIT to add: Nice to lighten up the dependencies a little bit, every bit helps.

[confused-Techie]

Thanks for the approval @DeeDeeG!