-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making autocomplete-plus work to replace ranges #479
Conversation
This is for choosing an autocomplete option when text is selected? How would one make the autocomplete menu appear in that scenario? |
Actually (and I should have opened this as Draft) it's to decide what to replace. Currently, Autocomplete works by: for example, if I type But some LSP providers allow for fuzzy-finder matches - like, I can type |
OK, so sounds like this wouldn't change any behavior for existing providers until they were updated to support it. Understood. |
Yes, the new version will only be used if some provider declares that it supports the new version. |
@mauricioszabo Hate to do this to you, but would you mind getting the newest changes from master so we can see green CI before a merge |
@confused-Techie after a couple months, done 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mauricioszabo Thanks a ton for taking the time to get this updated!
And the changes here look great, and love to see tests passing (Beside macOS failing to build, but that issue lies somewhere else, not here).
Especially having a solid spec to lean on for implementation details later, and being able to write up documentation for, this looks incredibly solid, and I say lets get this merged!
Ok, @confused-Techie, let me just update the changelog :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Lets get this merged
No description provided.