Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spell-check] Fixes for a possible patch release #1173

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[spell-check] Fixes for a possible patch release #1173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d851be
[spell-check] Change test so it works identically across platforms
savetheclocktower Dec 19, 2024
43eef86
[spell-check] Remove errant `console.log`…
savetheclocktower Dec 19, 2024
f6cfcaf
[spell-check] Revert addition to `spell-check.grammars`…
savetheclocktower Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/spell-check/lib/scope-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ class ScopeSelector {
enforceSegmentOrder: false,
...rawOptions,
};
console.log(this, 'matches', scopeDescriptorOrArray);
let scopeList;
if (Array.isArray(scopeDescriptorOrArray)) {
scopeList = scopeDescriptorOrArray;
Expand Down
1 change: 0 additions & 1 deletion packages/spell-check/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"grammars": {
"type": "array",
"default": [
"source comment",
"source.asciidoc",
"source.gfm",
"text.git-commit",
Expand Down
17 changes: 10 additions & 7 deletions packages/spell-check/spec/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
module.exports = {
env: { jasmine: true },
rules: {
"node/no-unpublished-require": "off",
"node/no-extraneous-require": "off",
"no-unused-vars": "off",
"no-empty": "off"
}
env: { jasmine: true },
globals: {
advanceClock: true,
},
rules: {
'node/no-unpublished-require': 'off',
'node/no-extraneous-require': 'off',
'no-unused-vars': 'off',
'no-empty': 'off',
},
};
4 changes: 2 additions & 2 deletions packages/spell-check/spec/spell-check-spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ class SpeledWrong {}`
`speledWrong = 5;
function speledWrong() {}
// We only care about mispelings in comments and strings!
let foo = "this is speled wrong"
let fxo = "this is speled wrong"
class SpeledWrong {}`
);

Expand Down Expand Up @@ -751,6 +751,7 @@ class SpeledWrong {}`
// These tests are only run on Macs because the CI for Windows doesn't have
// spelling provided.
if (env.isSystemSupported() && env.isDarwin()) {
let markers;
describe('when using system checker plugin', function () {
it('marks chzz as not a valid word but cheese is', async function () {
atom.config.set('spell-check.useSystem', true);
Expand All @@ -759,7 +760,6 @@ class SpeledWrong {}`

await conditionPromise(() => {
markers = getMisspellingMarkers();
console.log(markers);
return (
markers.length === 1 &&
markers[0].getBufferRange().start.column === 7 &&
Expand Down
Loading