Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linux trash error message #1151

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix Linux trash error message #1151

merged 1 commit into from
Dec 16, 2024

Conversation

mauricioszabo
Copy link
Contributor

gvfs-trash is deprecated and removed a long time ago. I think it's a good idea to fix this message so that users won't have the wrong idea on what might be wrong

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone ahead and re-run the failing jobs.

Based on other comments, and Electron themselves removing gvfs-trash themselves, this seems like a no brainer to update.

Thanks for getting to this one, looks good to me!

@confused-Techie
Copy link
Member

I'm going to say the failures here in CI are in no way related, and merge this one anyway. Thanks @mauricioszabo

@confused-Techie confused-Techie merged commit d754ed7 into master Dec 16, 2024
102 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants