Skip to content

Commit

Permalink
electron-builder: Restore "warningsAsErrors: false" to the new electr…
Browse files Browse the repository at this point in the history
…on-builder config file

We get the following, otherwise, it would seem:

  warning 6010: install function "EnvVarUpdate" not referenced - zeroing code (179-395) out

followed by:

  Error: warning treated as error

And then electron-builder exits with that as the error status.
So, I suppose we want to avoid that.
  • Loading branch information
DeeDeeG committed Oct 26, 2024
1 parent 27df7d7 commit bb7b273
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion script/electron-builder.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,8 @@ let options = {
// Hardcoding it here means it will always be used as generated from
// the AppID 'dev.pulsar-edit.pulsar'. If this value ever changes,
// A PR to GitHub Desktop must be made with the updated value.
include: "resources/win/installer.nsh"
include: "resources/win/installer.nsh",
warningsAsErrors: false
},

extraMetadata: {},
Expand Down

0 comments on commit bb7b273

Please sign in to comment.