Skip to content

Commit

Permalink
CI: Update code signing env var in GitHub Actions
Browse files Browse the repository at this point in the history
This is for newer electron-builder. This needs to be set, or else the
latest electron-builder won't attempt to sign/notarize for
Pull Requests.

We want to at least try this once, to try signing in this PR, and see
if the latest electron-builder version fixes the signing/notarizing
issue we have been seeing lately from our binaries built on
GitHub Actions?
  • Loading branch information
DeeDeeG committed Sep 23, 2023
1 parent 11cc4da commit 72e9b46
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ jobs:
# So if the PR is a fork, we will still build, but will not sign.
env:
CSC_LINK: ${{ secrets.CSC_LINK }}
CSC_FOR_PULL_REQUEST: ${{ secrets.CSC_LINK }}
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
APPLEID: ${{ secrets.APPLEID }}
APPLEID_PASSWORD: ${{ secrets.APPLEID_PASSWORD }}
Expand Down

0 comments on commit 72e9b46

Please sign in to comment.