Skip to content

Commit

Permalink
Address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
savetheclocktower committed Jan 11, 2024
1 parent c2e10f4 commit 58f76a8
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 13 deletions.
1 change: 0 additions & 1 deletion packages/spell-check/spec/spell-check-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ class SpeledWrong {}`
atom.config.set('spell-check.excludedScopes', ['.function.entity']);

{

await conditionPromise(() => getMisspellingMarkers().length > 0);
const markers = getMisspellingMarkers();
expect(markers.map((marker) => marker.getBufferRange())).toEqual([
Expand Down
1 change: 0 additions & 1 deletion spec/wasm-tree-sitter-language-mode-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3800,7 +3800,6 @@ describe('WASMTreeSitterLanguageMode', () => {
buffer.setLanguageMode(languageMode);
await languageMode.ready;
await wait(0);
console.log('TEXT:\n', editor.getText().replaceAll(' ', '_'));
editor.setCursorBufferPosition([2, 0]);
editor.insertText(' ');
await wait(0);
Expand Down
10 changes: 0 additions & 10 deletions spec/workspace-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2016,19 +2016,9 @@ describe('Workspace', () => {
atom2.deserializers
);

// HACK: This test rightly identified that our JS regexp injection grammar
// was using the `source.regexp.js` scope name instead of
// `source.js.regexp`. That change has been made in source, but these tests
// seem to be drawing packages from `node_modules`. Presumably this will be
// fixed once the name change propagates to a release. In the meantime,
// we'll fix it manually here just to make the test happy, then revert this
// hack later when it isn't needed.
let grammars = atom2.grammars
.getGrammars({ includeTreeSitter: true });

let grammarToFix = grammars.find(g => g.scopeName === 'source.regexp.js');
if (grammarToFix) grammarToFix.scopeName = 'source.js.regexp';

let grammarScopes = grammars.map(grammar => grammar.scopeName).sort();

expect(
Expand Down
2 changes: 1 addition & 1 deletion src/config-schema.js
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ const configSchema = {
type: 'boolean',
default: false,
title: 'Use Legacy Tree-sitter Implementation',
description: 'Opt into the legacy Atom Tree-sitter system instead of the modern system added by Pulsar. (This legacy system will soon be removed.) Has no effect unless “Use Tree-sitter Parsers” is also checked.'
description: 'Opt into the legacy Atom Tree-sitter system instead of the modern system added by Pulsar. (We plan to remove this legacy system soon.) Has no effect unless “Use Tree-sitter Parsers” is also checked.'
},
colorProfile: {
description:
Expand Down

0 comments on commit 58f76a8

Please sign in to comment.