Asyncify request #146
Asyncify request #146
Conversation
This is the version that passes all the existing tests. The HTTP requests used to be handled by a callback that had three arguments: one for the errors if there are any, one for the response and one for the payload within the response. Now, the error has been turned into rejected promises (exceptions when awaited) and the payload has simply been dropped. It's extracted from the response via the .body attribute.
This is the version that passes all the existing tests. The HTTP requests used to be handled by a callback that had three arguments: one for the errors if there are any, one for the response and one for the payload within the response. Now, the error has been turned into rejected promises (exceptions when awaited) and the payload has simply been dropped. It's extracted from the response via the .body attribute.
|
Unfortunately, GitHub isn't showing any diff on this PR. Although the changes you intended in this PR are still available on #147 so I'll see what I can do about reviewing them there, and chime in back here if need be. |
|
Yeah, it looks like there is one commit here with what I presume is the full intended diff, and a second commit with the same message but reverting the changes of the first commit. It may be possible to review this PR on the basis of the first commit, and to remember to delete the second commit before if/when it would be merged. |
|
I think since there has been (seemingly?) plenty of thought going into the other PR which does come with these changes, and not a lot of visible intent to fix/reuse this PR, perhaps it can be just closed at this point. The modifications in #147 still come in distinct commits so I don't think anything gets lost. |
This is basically #140 but now I didn't mess the branches up.