Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tag as a possible parameter to POST /packages #265

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mauricioszabo
Copy link

Requirements

  • Filling out the template is required.

  • All new code requires tests to ensure against regressions.

    • However, if your PR contains zero code changes, feel free to select the checkmark below to indicate so.
  • Have you ran tests against this code?

  • This PR contains zero code changes.

Description of the Change

Still a draft...

}

out.versions[PACKAGE_VER] = buildMeta(opts);
buildAbsentVer(PACKAGE_VER, opts)

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (95% of all statements in
the enclosing function
have an explicit semicolon).
let tag;
if(possibleTag) {
tag = await provider.tag(userObj, ownerRepo, possibleTag);
tag = tag.content

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (91% of all statements in
the enclosing function
have an explicit semicolon).
tags.content.sort((a, b) => {
return semver.rcompare(a.name, b.name);
});
tag = tags.content[0]

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (91% of all statements in
the enclosing function
have an explicit semicolon).
tag = await provider.tag(userObj, ownerRepo, possibleTag);
tag = tag.content
} else {
tags = await provider.tags(userObj, ownerRepo);

Check warning

Code scanning / CodeQL

Missing variable declaration Warning

Variable tags is used like a local variable, but is missing a declaration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant