Add support for any valid repository declaration during publication #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Filling out the template is required.
All new code requires tests to ensure against regressions.
Have you ran tests against this code?
This PR contains zero code changes.
Description of the Change
Previously the repository parameter validation was rather strict, using custom regex that would only accept a repository declared as
owner/repo
format. But since the parameter is taken directly from a user'spackage.json
repository
key, there's many different formats this could exist as.To ensure we support any valid format for a repository, I've moved this parameter away from the custom regex (there is still some custom regex to validate characters used and length limits, as those aren't present in the upstream module) to instead use
parse-github-url
and validate what that module says are theowner
andrepo
from the provided URL.Additionally, with this change I've ensured the publish endpoint can support any valid repository as well with the same module.