Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different pathwatcher #2

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Use different pathwatcher #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c9ddfe8
Updated pathwatcher
mauricioszabo Oct 23, 2022
02a2fea
Maybe?
mauricioszabo Oct 23, 2022
a658c5d
Don't ask...
mauricioszabo Oct 23, 2022
b773e5e
Bump pathwatcher
mauricioszabo Oct 31, 2022
565cfed
Back to pathwatcher...
mauricioszabo Nov 2, 2022
449b401
Back to pathwatcher...
mauricioszabo Nov 2, 2022
162ebf3
Electron 24
mauricioszabo Apr 12, 2023
8fbae43
Update workflow file for tests
confused-Techie Apr 12, 2023
210f4b1
Dummy commit to force now enabled actions to run
confused-Techie Apr 12, 2023
0007d03
Since this PR bumps to `electron` `24.0.0` lets use NodeJS `18` in ac…
confused-Techie Apr 13, 2023
135c1fc
Rebuild is failing, so lets try with newest `electron-rebuild`
confused-Techie Apr 13, 2023
28af9c6
Update `electron-rebuild` => `@electron/rebuild`
confused-Techie Apr 13, 2023
d351f4e
Follow `@electron/rebuild` docs
confused-Techie Apr 13, 2023
c008c4c
Follow the docs a little less exactly
confused-Techie Apr 13, 2023
d9b36d6
Move `electron-rebuild` into script to have NPM module resolution
confused-Techie Apr 13, 2023
001bdb0
Is `@electron/rebuild` not being installed as a devDep since `CI` is …
confused-Techie Apr 13, 2023
e8231ac
Okay don't worry about devDeps, just install
confused-Techie Apr 13, 2023
e4e0355
What if we don't rebuild?
confused-Techie Apr 13, 2023
e3cfddd
Merge remote-tracking branch 'origin/master' into use-different-pathw…
mauricioszabo Jul 31, 2023
49ae64d
Merge branch 'use-different-pathwatcher' of github.com:pulsar-edit/at…
mauricioszabo Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
name: CI

on: [push]
on:
- push
- pull_request

env:
CI: true
#env:
#CI: true

jobs:
Test:
Expand All @@ -12,15 +14,15 @@ jobs:
os: [ubuntu-latest, macos-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '18'
- name: Install dependencies
run: npm i
- name: Rebuild dependencies for Electron
run: npx electron-rebuild
run: npm install
#- name: Rebuild dependencies for Electron
# run: npm run rebuild
- name: Run tests
uses: GabrielBB/xvfb-action@v1
uses: coactions/setup-xvfb@v1.0.1
with:
run: npm test
Loading