Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAT-22998] Ensure Pulp closes the connection on corrupted streamed content #6026

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[SAT-22998] Ensure Pulp closes the connection on corrupted streamed content #6026

merged 1 commit into from
Nov 25, 2024

Commits on Nov 22, 2024

  1. Fix wrong package stream resulting in 200 Ok 

    Assuming we want to keep our stream-redirect approach on the
content-app, We cant recover from wrong data already sent if
the Remote happens to be corrupted (contains wrong binaries).

In order to not give a 200 reponse to client, we decided to
close the connection as soon as the request handler realizes
the checksum is wrong.

That only happens after we already sent the whole blob minus EOF,
so we close the connection before sending the EOF.

Additionally, we put some message on the logs for admins to see
and have a chance to manually fix the remote/remote_artifacts.

Co-authored-by: Matthias Dellweg <[email protected]>

fixes pulp#5012
    @pedro-psb
    pedro-psb committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    95da6b2 View commit details
    Browse the repository at this point in the history