README: Use the absolute URL of graphic #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the absolute URL of the Pulpino graphic makes it easier to render the README in other environments. LibreCores.org for example can render the README.md too, but has problems with relative URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
we are preparing the demo for the LibreCores.org launch scheduled today at ORCONF. We plan to use Pulpino as the demo project to show the basic project setup flow. For that we stumbled over a minor issue which is not trivial to fix on the LibreCores.org side: The README.md contains a relative URL which is a bit problematic to render generally (because a default git repository doesn't serve files).
It would be great if you merged this commit. The URL I used is the static URL suggested by Github.
Cheers,
Stefan