Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HW] cva6: Increase AXI data width #91

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

niwis
Copy link
Contributor

@niwis niwis commented Nov 18, 2021

Set Ariane's AXI data width to its data cache width (currently 512 bit)

Changelog

Changed

  • Update to CVA6 version with parametrised AXI data width
  • Separate AXI types for Ariane and Peripherals (so that the data widths are independent)

Checklist

  • Automated tests pass
  • Changelog updated
  • Code style guideline is observed

Make the Ariane AXI config independent of the peripheral AXI

Signed-off-by: Nils Wistoff <[email protected]>
@niwis niwis changed the title cva6: Widen AXI data width cva6: Increase AXI data width Nov 18, 2021
Copy link
Collaborator

@mp-17 mp-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts, Nils! Great work, especially on CVA6's side! ;-)
Only not 100% clear why we are upsizing the I$ line width as well

hardware/Makefile Show resolved Hide resolved
@@ -11,7 +11,7 @@ index 78ab0bf..5a70ccd 100644
localparam int unsigned ICACHE_SET_ASSOC = 4; // Must be between 4 to 64
localparam int unsigned ICACHE_INDEX_WIDTH = $clog2(CONFIG_L1I_SIZE / ICACHE_SET_ASSOC); // in bit, contains also offset width
localparam int unsigned ICACHE_TAG_WIDTH = riscv::PLEN-ICACHE_INDEX_WIDTH; // in bit
localparam int unsigned ICACHE_LINE_WIDTH = 256; // in bit
localparam int unsigned ICACHE_LINE_WIDTH = 512; // in bit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need wider I$ lines as well?

@@ -11,7 +11,7 @@ index 78ab0bf..5a70ccd 100644
localparam int unsigned ICACHE_SET_ASSOC = 4; // Must be between 4 to 64
localparam int unsigned ICACHE_INDEX_WIDTH = $clog2(CONFIG_L1I_SIZE / ICACHE_SET_ASSOC); // in bit, contains also offset width
localparam int unsigned ICACHE_TAG_WIDTH = riscv::PLEN-ICACHE_INDEX_WIDTH; // in bit
localparam int unsigned ICACHE_LINE_WIDTH = 256; // in bit
localparam int unsigned ICACHE_LINE_WIDTH = 512; // in bit
// D$
- localparam int unsigned CONFIG_L1D_SIZE = 32*1024;
- localparam int unsigned DCACHE_SET_ASSOC = 8; // Must be between 4 to 64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this should be true by default, now

@suehtamacv
Copy link
Contributor

@mp-17 Can we merge this? I guess it is more of a question of, is this the configuration you used for ASAP?

@mp-17 mp-17 changed the title cva6: Increase AXI data width [HW] cva6: Increase AXI data width Aug 30, 2022
@mp-17
Copy link
Collaborator

mp-17 commented Sep 28, 2022

Let's rebase this, modify the changelog, and launch a backend run!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants