-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HW] Add support for single lane configuration #194
Open
sharafat-10xEngineers
wants to merge
16
commits into
pulp-platform:main
Choose a base branch
from
10x-Engineers:single_lane
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[HW] Add support for single lane configuration #194
sharafat-10xEngineers
wants to merge
16
commits into
pulp-platform:main
from
10x-Engineers:single_lane
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharafat-10xEngineers
changed the title
Single lane
[HW] Add support for single lane configuration
Dec 14, 2022
Hi @mp-17 can you enable the CI for this PR? |
Thank you for opening this precious PR! I attach below the original draft work for reference (I closed the original PR): |
sharafat-10xEngineers
force-pushed
the
single_lane
branch
2 times, most recently
from
December 20, 2022 08:07
3bb509b
to
cadc92b
Compare
Hi @mp-17, Kindly enable the latest CI for this PR. |
sharafat-10xEngineers
force-pushed
the
single_lane
branch
from
December 23, 2022 09:01
cadc92b
to
8869796
Compare
sharafat-10xEngineers
force-pushed
the
single_lane
branch
from
December 28, 2022 10:17
8869796
to
c1c96c1
Compare
sharafat-10xEngineers
requested review from
suehtamacv and
mp-17
as code owners
January 11, 2023 09:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for the single lane support
This PR focuses on single lane with
VLEN = 128, 256, 512
. Also Default rv64uv tests are not ready to check the functionality for single lane configuration.Changelog
Changed
NrLanes == 1
case in the ara sequencer as there is no lane desynchronization problem in case of single lane.NrLanes == 1
case in lane sequencer where division of vector length is not required.NrLanes == 1
case in lane_sequencer where division of vstart is not required.NrLanes == 1
case to support single lane configuration.Checklist