Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging forks that were never merged into the official pug-cli #93

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

svallory
Copy link

In case anyone in the official repository wants an easy merge...

If not, you can get all this by from tokilabs/pug3-cli by installing the npm package @tokilabs/pug3-cli

Here's a list of the merged contributions:

borisovg and others added 28 commits May 3, 2021 19:05
@anduh/pug-cli - PUG 3 - 1.0.0
Merge contributions from @Anduh
Merge contributions from anthony-tron/yaml support
Add contributions from funai/master to allow YAML frontmatter
Previous implementation used 'lstatSync'  which returns stat info about link
itself, not the file that it refers to. That behaviour didn't allow to use the
tool in case of separate build (source and build dirs are separate, and sources
linked back into  build directory).

As workaround there we could provide file content through stdin, but that
approach has limitations:
- you cannot process multiple files at once
- you cannot use 'include' directives

This commit changes the use of  'lstatSync' to 'statSync' which makes symlink
files be processed as expected.
package.json Outdated Show resolved Hide resolved
@Anduh
Copy link

Anduh commented Jul 30, 2024

Did you change back so pug works as cli command, and not just pug3 that was a change made in the forks? (when I made my fork, I changed the command to pug3 so it could be installed alongside the official package and not, and this was incorporated into later pug-cli forks like tokilabs'.)

At least the documentation & examples still says pug3 is the command, so think it need to be added back as an alias for the cli command, or it would cause trouble for anyone who used pugjs/pug-cli and relies on the command being named pug (and not pug3).

There was a new issue opened on pugjs/pug discussion the situation: Pug-cli is unmaintained despite being mentioned in the readme #3444

Co-authored-by: Andreas J. <[email protected]>
@svallory
Copy link
Author

@Anduh nops. It is still pug3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants