Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add respect for extension property in options file #64

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add respect for extension property in options file #64

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2017

#63 resolved. Previously, it was not possible to define the extension in an options file.

@ghost
Copy link
Author

ghost commented Jul 14, 2017

Failing tests are a result of pug dependencies:
Command failed:
/home/travis/build/pugjs/pug-cli/node_modules/pug/node_modules/pug-parser/index.js:391

    const expr = this.parseExpr();
    ^^^^^

SyntaxError: Use of const in strict mode.

@codecov-io
Copy link

codecov-io commented Jul 14, 2017

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #64   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         145    146    +1     
=====================================
+ Hits          145    146    +1
Impacted Files Coverage Δ
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21bab2e...474359f. Read the comment docs.

@ghost
Copy link
Author

ghost commented Jul 15, 2017

pugjs/pug-parser#31

Issue causing failing builds

@ghost
Copy link
Author

ghost commented Jul 31, 2017

The const/var in strict mode issue has been resolved, but is not pushed to NPM yet:

pugjs/pug@e9dbadd

This pull request should solve these build issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant