Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH Actions script to include organization prefix #109

Merged
merged 2 commits into from
Oct 22, 2024
+10 −15
Merged

Update GH Actions script to include organization prefix #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b51b6ba
Update GH Actions script to include organization prefix
seba-aln Oct 22, 2024
65cd828
linter fixes
seba-aln Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/commands-handler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: Process command
if: github.event.issue.pull_request && endsWith(github.repository, '-private') != true
runs-on:
group: Default
group: organization/Default
steps:
- name: Check referred user
id: user-check
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
name: Check release required
if: github.event.pull_request.merged && endsWith(github.repository, '-private') != true
runs-on:
group: Default
group: organization/Default
outputs:
release: ${{ steps.check.outputs.ready }}
steps:
Expand All @@ -31,7 +31,7 @@ jobs:
needs: check-release
if: needs.check-release.outputs.release == 'true'
runs-on:
group: Default
group: organization/Default
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
tests:
name: Integration and Unit tests
runs-on:
group: Default
group: organization/Default
strategy:
max-parallel: 1
fail-fast: true
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
name: Tests
needs: [tests]
runs-on:
group: Default
group: organization/Default
steps:
- name: Tests summary
run: echo -e "\033[38;2;95;215;0m\033[1mAll tests successfully passed"
6 changes: 3 additions & 3 deletions .github/workflows/run-validations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
lint-project:
name: "Lint project"
runs-on:
group: Default
group: organization/Default
strategy:
max-parallel: 1
fail-fast: true
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
pubnub-yml:
name: "Validate .pubnub.yml"
runs-on:
group: Default
group: organization/Default
steps:
- name: Checkout project
uses: actions/checkout@v4
Expand All @@ -86,7 +86,7 @@ jobs:
name: Validations
needs: [pubnub-yml, lint-project]
runs-on:
group: Default
group: organization/Default
steps:
- name: Validations summary
run: echo -e "\033[38;2;95;215;0m\033[1mAll validations passed"
5 changes: 0 additions & 5 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3145,11 +3145,6 @@ parameters:
count: 1
path: src/PubNub/Models/Consumer/FileSharing/PNGetFileDownloadURLResult.php

-
message: "#^Method PubNub\\\\Models\\\\Consumer\\\\FileSharing\\\\PNGetFileDownloadURLResult\\:\\:__toString\\(\\) should return string but returns int\\.$#"
count: 1
path: src/PubNub/Models/Consumer/FileSharing/PNGetFileDownloadURLResult.php

-
message: "#^Method PubNub\\\\Models\\\\Consumer\\\\FileSharing\\\\PNGetFileDownloadURLResult\\:\\:getFileUrl\\(\\) has no return type specified\\.$#"
count: 1
Expand Down
2 changes: 1 addition & 1 deletion src/PubNub/CryptoModule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ public function parseInput(string | object $input): string
throw new PubNubResponseParsingException("Decryption error: message is not a string or object");
}

if (strlen($input) == '') {
if (trim($input) == '') {
throw new PubNubResponseParsingException("Decryption error: message is empty");
}
return $input;
Expand Down
2 changes: 1 addition & 1 deletion src/PubNub/Models/Consumer/FileSharing/PNGetFileDownloadURLResult.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public function __construct($result)

public function __toString()
{
return "Get file URL success with URL: %s" % $this->fileUrl;
return "Get file URL success with URL: {$this->fileUrl}";
}

public function getFileUrl()
Expand Down
Loading