Lockable immutable config #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seba-aln
force-pushed
the
feat/immutable-config
branch
3 times, most recently
from
ebb6012 to
6448e00
Compare
marcin-cebo
approved these changes
Jun 21, 2024
src/PubNub/PNConfiguration.php
Outdated
|
|
||
| /** @var string Secret key provided by PubNub */ | ||
| private $secretKey; | ||
| private ?string $secretKey = null; | ||
|
|
||
| /** @var string */ |
There was a problem hiding this comment.
Do we need this comment now that we have authKey typed?
The same question for other properties.
There was a problem hiding this comment.
I've added descriptions to them from the docs
| { | ||
| return (is_string($value) && strlen(trim($value)) > 0); | ||
| } | ||
|
|
||
| public function disableImmutableCheck(): self |
There was a problem hiding this comment.
so you can disable checking and on your own responsibility have a mutable config
seba-aln
force-pushed
the
feat/immutable-config
branch
2 times, most recently
from
912d445 to
b7b204f
Compare
seba-aln
force-pushed
the
feat/immutable-config
branch
from
b7b204f to
e87253e
Compare
marcin-cebo
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.