Reenable test

pubnub · Oct 16, 2023 · 4156f6d · 4156f6d
1 parent 825a5d8
commit 4156f6d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/src/PubNub/CryptoModule.php b/src/PubNub/CryptoModule.php
@@ -168,11 +168,7 @@ public function parseInput(string | object $input): string
             if (array_key_exists("pn_other", $input)) {
                 $input = $input["pn_other"];
             } else {
-                if (is_array($input)) {
-                    throw new PubNubResponseParsingException("Decryption error: message is not a string");
-                } else {
-                    throw new PubNubResponseParsingException("Decryption error: pn_other object key missing");
-                }
+                throw new PubNubResponseParsingException("Decryption error: pn_other object key missing");
             }
         } elseif (!is_string($input)) {
             throw new PubNubResponseParsingException("Decryption error: message is not a string or object");

diff --git a/src/PubNub/Models/Consumer/History/PNHistoryItemResult.php b/src/PubNub/Models/Consumer/History/PNHistoryItemResult.php
@@ -2,9 +2,9 @@
 
 namespace PubNub\Models\Consumer\History;
 
+use PubNub\Exceptions\PubNubResponseParsingException;
 use PubNub\PubNubCryptoCore;
 
-
 class PNHistoryItemResult
 {
     /** @var  any */
@@ -39,7 +39,9 @@ public function decrypt()
         if (is_string($this->entry)) {
             $this->entry = $this->crypto->decrypt($this->entry);
         } elseif (is_array($this->entry) and key_exists('pn_other', $this->entry)) {
-            $this->entry['pn_other'] = $this->crypto->decrypt($this->entry['pn_other']);
+            $this->entry = $this->crypto->decrypt($this->entry['pn_other']);
+        } else {
+            throw new PubNubResponseParsingException("Decryption error: message is not a string");
         }
     }
 

diff --git a/tests/integrational/HistoryTest.php → tests/integrational/TestPubNubHistory.php b/tests/integrational/HistoryTest.php → tests/integrational/TestPubNubHistory.php
@@ -330,7 +330,6 @@ public function testCountReverseStartEndSuccess()
 
     public function testProcessMessageError()
     {
-        $this->markTestSkipped('must be revisited.');
         $this->expectException(PubNubResponseParsingException::class);
         $this->expectExceptionMessage("Decryption error: message is not a string");