when priorities are equal do breadth first search #299
+12
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #298 has landed, the next steps are evaluate additional heuristics on a case-by-case basis. The obvious next most important from #291 is
discovery_order
. Thinking about it, almost all users could use this as a tiebreaker, and it costs next to nothing to calculate and the storage cost in priorities seems minimal. Overall, the cost to adding it to the documentation and telling all of our users to add it to their boilerplate seems higher than just always including it in the priority.Given that we would now have a reasonable default I thought about giving
prioritize
a default implementation. Unfortunately, it would need to return aSelf::Priority
and associated types cannot have a default value. :-(cargo run -r -- -m pub --with-solana --filter solana-archiver-lib -t 16
is now giving2.52min
, a massive improvement from7.56min
with dev.