Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: prop test for error report and refactor #129

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

Eh2406
Copy link
Member

@Eh2406 Eh2406 commented Jun 10, 2023

Removing a dependency from a dependency provider can only make more resolves succeed. Therefore, an interesting test is to look at our error reporting for some resolve, and we resolve with a dependency provider that only has dependency requirements mentioned in our report. If this subsequent run were to pass, then we have demonstrated that the error report did not include enough information to constitute a proof of unsatisfiability.

While working on the code I moved some code out of the proptest macro, as auto complete and formatting works better on non-macro code.

It would be nice to be able to test our proof of unsatisfiability against the failure information from the SAT solver. I was not able to figure out how to do this. I did find several small things that could be cleaned up about the implementation for SAT embedding.

@Eh2406 Eh2406 force-pushed the prop_test_for_report branch 3 times, most recently from 7ea5da5 to 4b9dd03 Compare June 12, 2023 17:57
@Eh2406
Copy link
Member Author

Eh2406 commented Jun 12, 2023

Rebased + happy clippy + fmt fix

@Eh2406 Eh2406 force-pushed the prop_test_for_report branch from 4b9dd03 to c751c38 Compare June 12, 2023 20:45
@Eh2406
Copy link
Member Author

Eh2406 commented Jun 12, 2023

Pull out some redundant code for checking with sat

@Eh2406
Copy link
Member Author

Eh2406 commented Jun 21, 2023

This just affects test code, so hopefully we can keep it moving.

@mpizenberg
Copy link
Member

Nice!
I have an end-of-quarter thing at work to prepare for monday, but after that I’ll fully review here.
Also getting a bit hyped up by packaging-con 2023 being announced so I’ll boost my time for pubgrub :)

@Eh2406
Copy link
Member Author

Eh2406 commented Sep 19, 2023

ping?

@Eh2406
Copy link
Member Author

Eh2406 commented Sep 23, 2023

Added a profile override to make (sat) tests run faster. Which let me run large_case on more files I had laying around, some of which had errors that were not NoSolution.

@Eh2406 Eh2406 force-pushed the prop_test_for_report branch 3 times, most recently from 61031d6 to 1761415 Compare September 25, 2023 22:13
@Eh2406
Copy link
Member Author

Eh2406 commented Sep 25, 2023

Backed out the override changes, even with the override the test was still too slow to run without --release, and with --release dependencies are already optimized.

@Eh2406 Eh2406 force-pushed the prop_test_for_report branch from 1761415 to 6fc85a5 Compare October 19, 2023 17:57
@Eh2406
Copy link
Member Author

Eh2406 commented Oct 19, 2023

Rebased. And this just affects test code, so starting a 10 day timer.

@Eh2406 Eh2406 force-pushed the prop_test_for_report branch from 6fc85a5 to 42867f9 Compare October 23, 2023 01:13
@Eh2406 Eh2406 force-pushed the prop_test_for_report branch from 42867f9 to fffa758 Compare October 30, 2023 16:36
@Eh2406
Copy link
Member Author

Eh2406 commented Oct 30, 2023

10 day timer is over with no objection. I will muck with settings so that I can self approve.

@Eh2406 Eh2406 merged commit 67e3be2 into dev Oct 30, 2023
5 checks passed
@Eh2406 Eh2406 deleted the prop_test_for_report branch October 30, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants