Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python <= 3.8 support and add 3.13 #588

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Drop Python <= 3.8 support and add 3.13 #588

merged 7 commits into from
Dec 9, 2024

Conversation

ptim0626
Copy link
Contributor

@ptim0626 ptim0626 commented Nov 25, 2024

This PR is some housekeeping of Python version support:

  • 3.8 reaches EOL so we should drop support
  • add 3.13 to the supported Python version
  • remove usage of pkg_resouces as it is removed from 3.13 (use importlib and packaging instead)

I switch over to conda-forge and I guess this is probably the better way going forwards given issues with packages in anaconda channel. Let me know if I miss anything.

@ptim0626 ptim0626 changed the title Drop Python <= 3.8 support and add 3.13 to CI tests Drop Python <= 3.8 support and add 3.13 Nov 25, 2024
@ptim0626
Copy link
Contributor Author

ptim0626 commented Nov 25, 2024

Ok Python 3.13 no longer has pkg_resources, so it is time to migrate to importlib, see https://importlib-resources.readthedocs.io/en/latest/migration.html.

WIP Done.

@daurer
Copy link
Contributor

daurer commented Dec 4, 2024

Hi Tim, many thanks for this PR. It looks good to me and I have confirmed that accelerated tests are passing ✔️
Happy to merge if @bjoernenders is happy as well!?

@daurer daurer merged commit 0c78215 into dev Dec 9, 2024
10 checks passed
kahntm pushed a commit that referenced this pull request Jan 8, 2025
* Drop Python <= 3.8 support

* Add py 3.13 in CI tests

* Use conda-incubator to set up conda env

* Ensure correct activation throughout the tests

* Migrate to importlib in script2rst

* Migrate to importlib in resources

* Migrate to packaging.version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants