Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of the top-level cmap registration and access functions in mpl.cm in plot_utils.py from matplotlib 3.9.0 #555

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

jcesardasilva
Copy link
Contributor

Hi everyone,

It has been a while since Matplotlib has been informing us about the deprecation of the top-level camp registration and access functions in mpl.cm, but now, in version Matplotlib 3.9.0, I noticed that the functions have definitely changed and it is no longer a simple deprecation warning. More details here: https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.9.0.html#top-level-cmap-registration-and-access-functions-in-mpl-cm

Since ptypy uses them often in plot_utils.py, I don't know what you plan to do.
I made the changes that worked for me, but I will let you check them. If I understood it correctly, those changes should be compatible with Matplotlib>3.6.0 from 2022, so if we implement them, ptypy should not be used with older versions of Matplotlib.

Please let me know what you decide. You can decline this PR if you want.

@jcesardasilva jcesardasilva changed the title Deprecation of the top-level cmap registration and access functions in mpl.cm in plot_utils.py from matplotlib 3.9.0 Deprecation of the top-level cmap registration and access functions in mpl.cm in plot_utils.py from matplotlib 3.9.0 Jun 27, 2024
@jcesardasilva
Copy link
Contributor Author

jcesardasilva commented Jun 27, 2024

Sorry, I did it on the master branch and should have done it in the dev branch, correct? I noticed that dev branch was some commits behind the master, but I did not want to make the rebase of it, which I Iet for the superdeveloppers @daurer and @bjoernenders

@daurer daurer changed the base branch from master to dev June 27, 2024 15:31
@daurer daurer self-assigned this Jul 17, 2024
@daurer daurer added the bug label Jul 17, 2024
@daurer daurer merged commit dd65a78 into dev Jul 17, 2024
9 of 10 checks passed
@daurer daurer mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants