Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Upsampling/Downsampling kernels #305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daurer
Copy link
Contributor

@daurer daurer commented Mar 12, 2021

No description provided.

Copy link
Contributor

@bjoernenders bjoernenders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See that one comment. Otherwise go ahead.

if kern.resample:
aux_tmp1 = np.abs(aux)**2
au.resample(aux_tmp2, aux_tmp1)
au.resample(aux_tmp1, aux_tmp2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks odd. Shouldn't the second resample be after make model?

@daurer daurer changed the base branch from gpu-hackathon to pycuda April 9, 2021 15:25
@daurer daurer force-pushed the gpu-hackathon-upsampling branch from 222e0a1 to 556d111 Compare April 9, 2021 15:59
@daurer daurer force-pushed the gpu-hackathon-upsampling branch from b375d7a to 3f756b5 Compare May 6, 2022 14:22
@daurer daurer changed the base branch from pycuda to master May 6, 2022 14:22
@daurer daurer changed the base branch from master to dev May 17, 2022 16:14
@daurer daurer changed the base branch from dev to master January 17, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants