Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility function void ChangeWindowFullMonitorWorkArea() like void… #130

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

Robxley
Copy link
Contributor

@Robxley Robxley commented Dec 10, 2024

Add a utility function ChangeWindowFullMonitorWorkArea() to resize the window with the monitor work area.
This new function works like ChangeWindowSize(...).

… ChangeWindowSize(...) but using the monitor work area to resize the window.
@pthom
Copy link
Owner

pthom commented Dec 10, 2024

Hi @Robxley

Many thanks for the PR, this is a good idea!

I'm a bit sensitive to naming. Could you change the name to something like WindowUseFullMonitorWorkArea (or you may propose another name inspired from this).

By the way, could you give me more info about the context in which you are using Hello ImGui.

Thanks!

@Robxley
Copy link
Contributor Author

Robxley commented Dec 10, 2024

Hi @pthom,

Thank you for your quick response 😁.
I completely agree with your naming suggestion; after all, it's your project 😊. WindowUseFullMonitorWorkArea is indeed more explicit.

Regarding your question about how I use Hello ImGui: I’ve been working with ImGui for a long time, especially in computer vision projects.
In my personal projects, I enjoy developing 3D/2D engines as a hobby (often for no particularly useful purpose 😋), and ImGui has always been my go-to tool for creating user interfaces for these wonderfully useless projects !

In my professional role as a computer vision engineer, I often need to track and display video and image processing results from existing production pipelines. ImGui is very convenient in these contexts, particularly because it is easy to use across different platforms and integrates seamlessly with existing computer vision production engines.

I recently discovered Hello ImGui, and it perfectly addresses the needs of creating cross-platform applications without any pain. I wouldn’t have had the time (and your expertise) to achieve such an integration on my own.

Thanks to your great work, Hello ImGui is straightforward to use and makes it very simple to set up a new app.

Why reinvent an (probably unstable) wheel ... 😁
And if I can contribute occasionally with some humble new features, I’d be happy to help!

Have a good day.
Robxley

@Robxley
Copy link
Contributor Author

Robxley commented Dec 10, 2024

Hi again,

I may have answered too quickly regarding the function name.

In your code, the function for resizing is named ChangeWindowSize. To keep the syntax consistent (action + description), perhaps UseWindowFullMonitorWorkArea would be a better fit than WindowUseFullMonitorWorkArea.

What do you think?
Robxley

@pthom
Copy link
Owner

pthom commented Dec 10, 2024

In your code, the function for resizing is named ChangeWindowSize. To keep the syntax consistent (action + description), perhaps UseWindowFullMonitorWorkArea would be a better fit than WindowUseFullMonitorWorkArea.

Perfect! Can you please push a modified version?

@pthom
Copy link
Owner

pthom commented Dec 10, 2024

In my professional role as a computer vision engineer, I often need to track and display video and image processing results from existing production pipelines.

You might be interested in ImmVision, which I also developed, and which is part of ImGui Bundle.

See demo, and click on the ImmVision tab:
image

@pthom pthom merged commit 13e6bd4 into pthom:master Dec 10, 2024
37 checks passed
@pthom
Copy link
Owner

pthom commented Dec 10, 2024

Merged, thanks a lot.

PS: I was a computer vision engineer in a previous life.

@Robxley
Copy link
Contributor Author

Robxley commented Dec 12, 2024

Thank you for the tips about ImmVision.
When I came across hello_imgui, I also explored your GitHub. 😄
I’ve seen ImmVision—it looks very interesting, similar to the Image Watch extension for Visual Studio but with more tools.
I haven’t had a chance to use it yet, but maybe someday! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants