-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telescope integration #16
base: main
Are you sure you want to change the base?
Conversation
…lescope.load_extension. Renamed the yankbank_picker function to yankbank in the yankbank extension.
…reg_types and corrected function definitions.
…d `reg_types` to the picker.
…the yankbank module
Thanks for the PR! Telescope integration is something I'd be happy to merge in when its ready. I just tested this, and it is erroring out when selecting an entry from the telescope menu:
Taking a look at line 35, it appears that vim.tbl_index is not a valid function, but it should be pretty simple to modify the code to get the entry index (a loop would suffice as the table is quite small). Transitioning to some minor feedback, I think it would be nice if it used the telescope split previewer when the editor window is sufficiently large, and I would like the newline display character to be set with an option as I don't personally like using glyph characters (but I'm fine with it being the default option). Please reach out if you have any questions, and thanks again for the contributions. |
Follows https://github.com/nvim-telescope/telescope.nvim/blob/master/developers.md
beware I haven't had the chance to test thoroughly, it is a freshly baked implementation