Some Fixes #72
Closed
Some Fixes #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psu-de
reviewed
Aug 13, 2024
| @@ -450,7 +486,10 @@ private Task HandleOpenWindow(OpenWindowPacket packet) | |||
|
|
|||
| windowInfo = windowInfo with { Title = packet.WindowTitle }; | |||
| Logger.Debug($"Received Open Window Packet id={packet.WindowId}"); | |||
| OpenWindow(packet.WindowId, windowInfo); | |||
| Task.Delay(100).ContinueWith(t => | |||
There was a problem hiding this comment.
Is there a reason why we wait 100ms before opening the window?
There was a problem hiding this comment.
i think i sent a video on the discord addressing that temporal change you may want to watch it, i still didn't found the reason of why the task never executes and always times out, but adding a delay make it works.
There was a problem hiding this comment.
hm seems to be a race condition. PR #71 addresses a lot of bugs regarding race conditions, maybe it fixes it.
|
With entity position there was also a problem where the SetVelocityPacket set the velocity of the entity as their position and thus entities often have almost zero coordinates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that entity positions where abnormal and i found out the problem was a typo where we were setting the position to the actual delta change