Skip to content

Commit

Permalink
[auto run retry tags] 2/n - Add dagster/will_retry tag to runs that…
Browse files Browse the repository at this point in the history
… fail (dagster-io#25932)

## Summary & Motivation
Based on discussion in
dagster-io#25771 (comment)

We don't have a centralized way to determine if a run is going to be
retried by the retry daemon. This results in different methods being
used throughout the code base.

This PR adds a `dagster/will_retry` tag to any run that will be retried
according to the retry maximums set by the user.
`dagster/will_retry=false` is applied to any run that failed, but will
not be retried

This PR does not change how the re-execution daemon decides if a run
should be retried. That is in a stacked PR so that we have more control
over how the changes are rolled out

associated internal pr https://github.com/dagster-io/internal/pull/12765

## How I Tested These Changes
updated existing tests for auto reexecution to assert that the tag
exists when we expect it to
  • Loading branch information
jamiedemaria authored and pskinnerthyme committed Dec 16, 2024
1 parent 924859d commit d6384d2
Show file tree
Hide file tree
Showing 5 changed files with 329 additions and 158 deletions.
Loading

0 comments on commit d6384d2

Please sign in to comment.