Use automatic memory instead of dynamic one for storing DoubleSlider …

…example object.
przemek83 · Dec 26, 2024 · 485b87c · 485b87c
1 parent 70882a0
commit 485b87c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/examples/Examples.cpp b/examples/Examples.cpp
@@ -9,15 +9,14 @@
 #include <QVBoxLayout>
 #include <QWindow>
 
-#include <wble/DoubleSlider.h>
 #include <wble/FilterDates.h>
 #include <wble/FilterDoubles.h>
 #include <wble/FilterIntegers.h>
 #include <wble/FilterStrings.h>
 #include <wble/ProgressBarCounter.h>
 #include <wble/ProgressBarInfinite.h>
 
-Examples::Examples() : info_(QStringLiteral("Status"))
+Examples::Examples() : info_(QStringLiteral("Status")), doubleSlider_{MIN, MAX}
 {
     setWindowTitle("Wble library examples");
     QHBoxLayout* widgetLayout{new QHBoxLayout(this)};
@@ -28,16 +27,15 @@ Examples::Examples() : info_(QStringLiteral("Status"))
     setLayout(widgetLayout);
 }
 
-DoubleSlider* Examples::createDoubleSlider()
+DoubleSlider* Examples::getDoubleSlider()
 {
-    auto* slider{new DoubleSlider(MIN, MAX)};
-    QObject::connect(slider, &DoubleSlider::currentMinChanged, this,
+    QObject::connect(&doubleSlider_, &DoubleSlider::currentMinChanged, this,
                      &Examples::doubleSliderMinChanged);
 
-    QObject::connect(slider, &DoubleSlider::currentMaxChanged, this,
+    QObject::connect(&doubleSlider_, &DoubleSlider::currentMaxChanged, this,
                      &Examples::doubleSliderMaxChanged);
 
-    return slider;
+    return &doubleSlider_;
 }
 
 FilterNumbers* Examples::createFilterIntegers()
@@ -110,7 +108,7 @@ QVBoxLayout* Examples::createLeftWidgetColumn()
     leftLayout->setSpacing(DEFAULT_SPACING);
     auto* groupBox{new QGroupBox(QStringLiteral("Double Slider"))};
     auto* layout{new QVBoxLayout(groupBox)};
-    layout->addWidget(createDoubleSlider());
+    layout->addWidget(getDoubleSlider());
     groupBox->setLayout(layout);
     leftLayout->addWidget(groupBox);
     leftLayout->addWidget(createFilterIntegers());

diff --git a/examples/Examples.h b/examples/Examples.h
@@ -3,7 +3,8 @@
 #include <QLabel>
 #include <QWidget>
 
-class DoubleSlider;
+#include <wble/DoubleSlider.h>
+
 class FilterNumbers;
 class FilterDates;
 class FilterStrings;
@@ -18,7 +19,7 @@ class Examples : public QWidget
     Examples();
 
 private:
-    DoubleSlider* createDoubleSlider();
+    DoubleSlider* getDoubleSlider();
     FilterNumbers* createFilterIntegers();
     FilterNumbers* createFilterDoubles();
     FilterDates* createFilterDates();
@@ -39,6 +40,8 @@ class Examples : public QWidget
 
     QLabel info_;
 
+    DoubleSlider doubleSlider_;
+
 private slots:
     void doubleSliderMinChanged(double min);
     void doubleSliderMaxChanged(double max);