Skip to content

Commit

Permalink
- upgrading android dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
prscms committed Nov 1, 2018
1 parent f3a044a commit 322326d
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 10 deletions.
2 changes: 1 addition & 1 deletion Example/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def enableProguardInReleaseBuilds = false

android {
compileSdkVersion 27
buildToolsVersion "27.0.3"
buildToolsVersion '28.0.3'

defaultConfig {
applicationId "com.example"
Expand Down
8 changes: 4 additions & 4 deletions Example/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

buildscript {
repositories {
jcenter()
google()
maven { url "https://maven.google.com" }
maven { url "https://jitpack.io" }
google()
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.1.3'
classpath 'com.android.tools.build:gradle:3.2.1'

// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
Expand All @@ -18,12 +18,12 @@ buildscript {
allprojects {
repositories {
mavenLocal()
jcenter()
maven { url "https://maven.google.com" }
maven { url "https://jitpack.io" }
maven {
// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
url "$rootDir/../node_modules/react-native/android"
}
jcenter()
}
}
4 changes: 2 additions & 2 deletions Example/android/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Wed May 30 18:27:15 IST 2018
#Thu Nov 01 11:05:42 IST 2018
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-all.zip
7 changes: 7 additions & 0 deletions RNAppTour.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ class AppTourView {
throw new Error(
'Provided tour view reference is undefined or null, please add a preliminary validation before adding for tour.'
)

if (
view._reactInternalFiber === undefined ||
view._reactInternalFiber === null) {
throw new Error("Tour view does not have React Internal Fiber.");
}

if (
view._reactInternalFiber.key === undefined ||
view._reactInternalFiber.key === null
Expand Down
4 changes: 2 additions & 2 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:3.0.1'
classpath 'com.android.tools.build:gradle:3.2.1'
}
}

apply plugin: 'com.android.library'

android {
compileSdkVersion 27
buildToolsVersion "27.0.3"
buildToolsVersion '28.0.3'

defaultConfig {
minSdkVersion 16
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-app-tour",
"version": "0.0.16",
"version": "0.0.17",
"description": "React Native: Native App Tour Library",
"repository": {
"type": "git",
Expand Down

0 comments on commit 322326d

Please sign in to comment.