Merge updates of safe global #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add twap tests
* chore: create a wrapper on top of signOrExecuteForm to fetch async data before showing the ui * chore: show the confirmation view component based on the transaction type * chore: move presentational layer of reviewOwner to SettingsChange component * chore: do not use showMethodCall to signOrExecuteForm component * feat: Add a loader in the signOrExecuteForm component while the necessary data is not fetched * fix: unit tests * fix: lint errors * mend * fix: pass the txInfo in the useTxDetails mock to avoid null pointer exception * fix: generated snapshots * fix: generated snapshots * fix: change the fundReceiver address on snapshots * fix: remove unnecessary casting * chore: rename useDetailsHook to be useProposeTx * fix: grab the transaction id from the txDetails in case the txId is not provided * fix: rename file from utils to mockData * chore: move the settings component to be exported directly in the index file * fix: add the batch button back to the confirmation views * fix: use the txData component in the confirmation view in case any confirmation view component is found * feat: show an error screen if something happens while fetching the txDetails * fix: show contract name when it is a multisend transaction * fix: eslint errors * fix: move error condition to top of the confirmation view component * fix: do not propose transaction for contrafactual safes * fix: cypress drain e2e test * fix: remove duplicated data in the DecodedTx component * fix: Add back showMethodCall and keep prop drilling it * fix: do not show method call for approve transactions * fix: add showMethodCall into the confirmationView component * fix: pass isApproval down to the confirmation view component * fix: Add isCreation check inside DecodedTx to render partial summary * fix: Update snapshot and mock hex data generation to be even length * chore: generated snapshots * chore: refactor changeThresholdReview screen (safe-global#4212) * Approval editor * Fix error display in confirmation screen * chore: unify confirmBatch screen (safe-global#4217) * fix(account-flow-import): change import src in the recover account flow screen * fix(eslint): eslint hook dependencies * fix(unit-tests): change txDetails mocked data in unit tests * fix(eslint): change operators order * fix(unit-tests): mock useSafeAddress hook * fix(settings-change): add address name in the change owner screen * fix(settings-change): duplicated owner name in the add owner flow --------- Co-authored-by: Usame Algan <[email protected]> Co-authored-by: katspaugh <[email protected]>
Add tests for multichain sidebar
* Feat: indexing status (SWS-134) * Add a tooltip * fix: don’t use nested ternaries --------- Co-authored-by: Daniel Dimitrov <[email protected]>
* init * feat: Add remove delegate option and adjust delegate list layout (safe-global#4390) * feat: Add remove delegate button, adjust delegate list layout * feat: Update gateway-sdk package, add delegate form * feat: Optimistically update delegates cache when adding or removing delegate * fix: Add missing ga events, add enum * chore: Update gateway-sdk package * fix: Update setup settings layout * fix: Add notifications when adding and removing proposer * fix: Add validation for add proposer * fix: Rename delegate to proposer * fix: Rename variable for add proposer dialog * fix: Align remove icons in tables * fix: Handle update proposer in rtk query * feat: Show Proposal chip for unsigned transactions in the queue (safe-global#4422) * feat: Allow deletion of delegate transactions from the queue [SW-297] (safe-global#4400) * init * feat: Allow deletion of delegate transactions from the queue * feat: Add text to signer view if tx is from proposer * fix: Disable add proposer and delete proposer [SW-400] [SW-396] (safe-global#4429) * fix: Disable add proposer and delete proposer * fix: Account for owners that are proposers in CheckWallet * fix: Adjust message when proposing transaction (safe-global#4435) * feat: Edit proposer dialog [SW-391] [SW-396] (safe-global#4436) * feat: Show proposer address in queue (safe-global#4443) * fix: Hide tooltip on confirm button for proposers (safe-global#4444) * fix: Use safe owner address for tenderly simulation with proposer (safe-global#4445) * fix: Only show proposal chip if transaction is not pending (safe-global#4450) * fix: Allow owners to be added as proposers [SW-407] [SW-428] [SW-381] (safe-global#4446) * fix: Remove scrollbar when adding proposer * fix: Allow owners being added as proposers * fix: Add check that isProposing only when its also a creation * fix: Update testid to fix add owner smoke test * fix: Hide batch button for proposers (safe-global#4457) * feat: Support hardware wallets for adding and removing proposers (safe-global#4466) * feat: Display creator in the proposer list [SW-408] [SW-470] (safe-global#4471) * feat: Display creator in proposer list * fix: Correctly update proposers when editing and deleting * fix: Remove dangling console.log * fix: Add network switch to delete proposer dialog and reset values when closing * fix: AdjustVInSignature when managing proposers with a hardware wallet (safe-global#4477) * fix: Add proposers feature flag (safe-global#4488)
Adds components that decode the child transaction for `approveHash` and `execTransaction` calls. Co-authored-by: Tim Schwarz <[email protected]>
safe-global#4463) * fix(staking-tx): Add staking condition back into the confirmation view * fix(staking-confirmation): remove typo
safe-global#4463) * fix(staking-tx): Add staking condition back into the confirmation view * fix(staking-confirmation): remove typo
* Update tests
* fix: Blockaid warning color * fix: Adjust spacing and font weight for blockaid warning
* fix: Update privacy policy * fix: Remove privacy.md.d.ts * refactor: Extract CustomLink component * fix: Update privacy policy style
* Add multichain tests
* Add more multichain tests
…shold confirmation screen (safe-global#4465) * fix(threshold-info): remove 0 information from the threshold confirmation screen * fix(threshold-info): use isChangeThresholdView guard
…fe-global#4366) Bumps [@web3-onboard/walletconnect](https://github.com/blocknative/web3-onboard/tree/HEAD/packages/walletconnect) from 2.5.4 to 2.6.1. - [Release notes](https://github.com/blocknative/web3-onboard/releases) - [Commits](https://github.com/blocknative/web3-onboard/commits/HEAD/packages/walletconnect) --- updated-dependencies: - dependency-name: "@web3-onboard/walletconnect" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…4530) Bumps the npm_and_yarn group with 1 update: [cross-spawn](https://github.com/moxystudio/node-cross-spawn). Updates `cross-spawn` from 7.0.3 to 7.0.5 - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.5) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# Conflicts: # package.json # src/components/tx/SignOrExecuteForm/SignOrExecuteForm.tsx
* Chore: upgrade React to 19 stable * Adjust ai review prompt
Bumps [webpack](https://github.com/webpack/webpack) from 5.95.0 to 5.97.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.95.0...v5.97.1) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: upgrade transactions for 1.0.0 Safes * fix: test description Co-authored-by: Aaron Cook <[email protected]> --------- Co-authored-by: Aaron Cook <[email protected]>
…global#4598) Co-authored-by: Aaron Cook <[email protected]>
…e-global#4616) * fix: don't use `chainId` when calculating domain hash of <=1.2.0 * Extract check to variable
* 4.1.2 * Update tests
* Chore: Update protocol kit to add new network * Rm generated line --------- Co-authored-by: katspaugh <[email protected]>
* Fix: crossorigin anonymous for token icons + fix token pair arrow * Update snapshots * Revert crossorigin
…4] (safe-global#4630) * feat: include last visited safes in import/export data * fix: prevent unecessary requests when wallet is undefined and retry with backoff when gateway returns 503 * use empty object as default for AllOwnedSafes type * Add visited safes to import and export previews
* fix: Remove cache in useAllOwnedSafes * fix: Write tests for useAllSafes * fix: Add more tests for useAllSafes * refactor: Extract useAllSafes logic into separate functions * refactor: Extract useHasSafes, remove sorting, iterate over all chains * fix: Write test cases for buildSafeItem and prepareAddresses * fix: Implement tests for _prepareAddresses and _buildSafeItem * fix: Check undeployed safe owners to determine readOnly status * fix: Remove condition * fix: Remove isOwnerOfAddedSafe check
* Fix: pass sx prop to Box and Typography * Add tests
* fix: Add sorting back to useAllSafes hook * chore: Add comment explaining why we sort
…4643) * fix: allow removing counterfactual safes from safe list * fix: handle multi chain CF safes
…435] (safe-global#4622) * fix: Show raw data if decodedData doesn't contain any parameters * fix: Show hexData if there are no parameters * Update src/components/transactions/TxDetails/TxData/DecodedData/MethodDetails/index.tsx Co-authored-by: katspaugh <[email protected]> --------- Co-authored-by: katspaugh <[email protected]>
…fe (safe-global#4657) * fix: Adjust sidebar search input design, show notifications on pin safe * fix: Show short address or name in notification
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #
How this PR fixes it
How to test it
Screenshots
Checklist