Feature: add custom network #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bogos
commented
Nov 13, 2023
•
bogos
commented
- Add custom network modal selector
- Validate selected network
…rd into feature/add-custom-network
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…rd into feature/add-custom-network
|
The code in the previous commit is functional but appears messy and lacks clarity due to asynchronous operations within useEffect. Despite its smelly nature, it successfully initializes the API and manages state. Consider refactoring for improved readability when possible. |
henrypalacios
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Great changes @bogos 🤝.
I will merge and leave you the commentary on what needs to be improved.
|
|
||
| useEffect(() => { | ||
| if (networkConnected) { | ||
| if (!fetchApi) { |
There was a problem hiding this comment.
🤔 This logic is not stable, what happen if fetchApi returns after useEffect is executed?
0xLucca
approved these changes
Nov 16, 2023
| } | ||
| } | ||
|
|
||
| const formData = { | ||
| name: useFormInput<string>('test', [notEmpty]), |
There was a problem hiding this comment.
Here in the form data the placeholder for the name seems like an address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.