Add Contract Table / Share Modal #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…lkadot-contract-wizard into feature/contract-page-table
henrypalacios
requested changes
Oct 5, 2023
| ) | ||
| } | ||
|
|
||
| const searchMetadata = async (codeId: string): Promise<string | void> => { |
There was a problem hiding this comment.
You are repeating this code that I have created, how about taking inspiration from the principle of segregation and extracting it to a hook to reuse it in both components?
src/pages/contracts/index.tsx
Outdated
| return ( | ||
| <Box | ||
| sx={{ | ||
| width: { sm: '90%', md: '75%', lg: '80%', xl: '60%' }, | ||
| margin: '0 auto 2rem auto' | ||
| }} | ||
| > | ||
| <Typography variant="h1" align="center"> | ||
| Contracts | ||
| <Typography variant="h1" align="left"> |
There was a problem hiding this comment.
This made sense when there were only 2 different pages, now we have to think about creating a container layout for the pages. (out this PR)
cc @alongoni
henrypalacios
requested changes
Oct 5, 2023
| custom: { | ||
| title: 'CUSTOM', | ||
| subtitle: 'Standard smart contract for a custom Token', | ||
| imgPath: TOKEN_PATHS.psp37, |
There was a problem hiding this comment.
I will approve this PR, however, this image needs to be updated and the other contract types need to be verified.
cc @alongoni
This was referenced Oct 23, 2023
Merged
henrypalacios
added a commit
that referenced
this pull request
Nov 9, 2023
* Adding contracts route * Add Custom Contracts and Contracts section (#195) * add custom option on home * add HomeButtonHorizontal variant * refactor CustomContract component * fix layout * add dashboard page and menu * rm contract form dashboard menu and add icon * Dashboard --> Contracts * change folder name to contracts * img uppercase * add styles refactor * Add Contract Table / Share Modal (#217) * add contract table in contracts page * add share contract modal * add view when no wallet is connected, refactor share modal * fix lint error * fix pr comments * fix pr typos * remove duplicated tittle * replace textfield component --------- Co-authored-by: Agustín Longoni <[email protected]> Co-authored-by: Agustín Longoni <[email protected]> * Add last contracts (#229) * add last contracts table * add mt * add network badge component * move view all contract link * fix missing type error * Add import form section (#201) * add gap to next/back buttons * add custom contract basic page * add dropzone component * working on drag and drop logic * fix error * custom --> custom-contract route * Fixing custom page * Adding codeHash comparison * Fixing ts definition errors * Checking validation hash * Display message when contract is imported * Fix converted initialSupply --------- Co-authored-by: Henry Palacios <[email protected]> * Feature/ Contrat table edit name and delete contract (#232) * add contract table in contracts page * add share contract modal * add view when no wallet is connected, refactor share modal * fix lint error * fix pr comments * fix pr typos * add edit option * add contract table edit name and delete * refactor code and remove item from table when is hidden * add missing UserContractDetails attribute * add dropdown filter and fix table re-render * rename file and fix imports * remove show test in contract widget, add missing custom typos * add custom missing properties * fix pr comments * add EmptyString typo --------- Co-authored-by: Agustín Longoni <[email protected]> * Fix infinite contract table loop (#244) * fix infinite contract table loop * update yarnlock * fix problem with typos * Contracts UI + Layout fixes (#238) * fix table size * change save icon * tablehead caption * fix layout * add MainContainer component - layout * fix breackpoint sizes * add tooltip on contracts page * add tooltip on contract home * add isoDate format * add docstring * Contract details view layout (#231) * add contract detail page * accordion and tabs components * layout improvements * refactor on accordion and add contract address * accordion styles * fix styles * add tab logic * addn styles * add icons * add tab logic * wording * add networkbadge * add disabled styles * Revert "Contract details view layout (#231)" This reverts commit 8979c19. * Fix minnor bugs in contracts page table (#246) * add input lenght validator and message * fix problem with loading state * add default name for empty contracts names * fix problem with listing date * import custom deployment (#245) * Fix contract_name input * Create custom contract fn * Merging the loop solution in home * Refactoring * Fixing name typo error * Adding toast notification * Fixing newDeploy on Step3 * Parsin Record to json string * fix layout * Fixing custom Token img on contracts table * Adding useForm * Fixing deploy psp contracts * Fix typo on Routes --------- Co-authored-by: Agustín Longoni <[email protected]> * fix minnor custom contracts bugs * fix contract table rerender bug * Fix minnor bugs (#255) * fix minnor bug * fix an error with the list of contracts when changing accounts * fix problem with updates, readd listener * Form styles and layout fixes (#247) * add fixed back and next buttons * add input styles * add dropzone border color * fix back button styles * fix back and next container * fix form colors and add autoFocus * rmv unused component * change position * load custom contract (#248) * Adding Redirection * Removing old folder * Fixing yarn lock * skeleton improvements * fix layout and add isoDate tooltip * remove maincontainer * CI errors' * Renderazing dynamic page * Avoid use network con ContractDetail * Avoid use network con ContractDetail again * Trying fix network error * Removing contract API * Removing Domain on apiBaseUrlPath * Using basePath based on the environment * Removing console * Using VERCEL_URL * Trying another order * Using URL_params instead of dynamic URL * Getting metadata when not is downloaded * Adding Redirection with uuid after create contract --------- Co-authored-by: Agustín Longoni <[email protected]> * Tables UI Improvements + New Documentation (#256) * add json metadata to actions * move contract table to homepage * add Last contract titte and network * improve no contracts message * move table to components * table refactor * fix errors * clean code * remove old documentation and add new external documentation * remove doc tests * refactor WIP Co-authored-by: Henry Palacios <[email protected]> * Donwload metadata on contracts table * Fix typo on useDonwloadSource * Improve the downloaded file name --------- Co-authored-by: Andre Neyra <[email protected]> Co-authored-by: Henry Palacios <[email protected]> Co-authored-by: Henry Palacios <[email protected]> * connection validations (#257) * Adding validatino when no connected * AutoFocus on editContractName * interaction methods (#265) * Get Sorted methods * Adding Inputs to form on each method * Use registry instead of contract Promise * Rename files * Fixing typod error files * Rollback eslint --------- Co-authored-by: Agustín Longoni <[email protected]> Co-authored-by: AndrN <[email protected]> Co-authored-by: Agustín Longoni <[email protected]> Co-authored-by: Henry Palacios <[email protected]>
henrypalacios
added a commit
that referenced
this pull request
Nov 13, 2023
* Adding contracts route * Add Custom Contracts and Contracts section (#195) * add custom option on home * add HomeButtonHorizontal variant * refactor CustomContract component * fix layout * add dashboard page and menu * rm contract form dashboard menu and add icon * Dashboard --> Contracts * change folder name to contracts * img uppercase * add styles refactor * Add Contract Table / Share Modal (#217) * add contract table in contracts page * add share contract modal * add view when no wallet is connected, refactor share modal * fix lint error * fix pr comments * fix pr typos * remove duplicated tittle * replace textfield component --------- Co-authored-by: Agustín Longoni <[email protected]> Co-authored-by: Agustín Longoni <[email protected]> * Add last contracts (#229) * add last contracts table * add mt * add network badge component * move view all contract link * fix missing type error * Add import form section (#201) * add gap to next/back buttons * add custom contract basic page * add dropzone component * working on drag and drop logic * fix error * custom --> custom-contract route * Fixing custom page * Adding codeHash comparison * Fixing ts definition errors * Checking validation hash * Display message when contract is imported * Fix converted initialSupply --------- Co-authored-by: Henry Palacios <[email protected]> * Feature/ Contrat table edit name and delete contract (#232) * add contract table in contracts page * add share contract modal * add view when no wallet is connected, refactor share modal * fix lint error * fix pr comments * fix pr typos * add edit option * add contract table edit name and delete * refactor code and remove item from table when is hidden * add missing UserContractDetails attribute * add dropdown filter and fix table re-render * rename file and fix imports * remove show test in contract widget, add missing custom typos * add custom missing properties * fix pr comments * add EmptyString typo --------- Co-authored-by: Agustín Longoni <[email protected]> * Fix infinite contract table loop (#244) * fix infinite contract table loop * update yarnlock * fix problem with typos * Contracts UI + Layout fixes (#238) * fix table size * change save icon * tablehead caption * fix layout * add MainContainer component - layout * fix breackpoint sizes * add tooltip on contracts page * add tooltip on contract home * add isoDate format * add docstring * Contract details view layout (#231) * add contract detail page * accordion and tabs components * layout improvements * refactor on accordion and add contract address * accordion styles * fix styles * add tab logic * addn styles * add icons * add tab logic * wording * add networkbadge * add disabled styles * Revert "Contract details view layout (#231)" This reverts commit 8979c19. * Fix minnor bugs in contracts page table (#246) * add input lenght validator and message * fix problem with loading state * add default name for empty contracts names * fix problem with listing date * import custom deployment (#245) * Fix contract_name input * Create custom contract fn * Merging the loop solution in home * Refactoring * Fixing name typo error * Adding toast notification * Fixing newDeploy on Step3 * Parsin Record to json string * fix layout * Fixing custom Token img on contracts table * Adding useForm * Fixing deploy psp contracts * Fix typo on Routes --------- Co-authored-by: Agustín Longoni <[email protected]> * fix minnor custom contracts bugs * fix contract table rerender bug * Fix minnor bugs (#255) * fix minnor bug * fix an error with the list of contracts when changing accounts * fix problem with updates, readd listener * Form styles and layout fixes (#247) * add fixed back and next buttons * add input styles * add dropzone border color * fix back button styles * fix back and next container * fix form colors and add autoFocus * rmv unused component * change position * load custom contract (#248) * Adding Redirection * Removing old folder * Fixing yarn lock * skeleton improvements * fix layout and add isoDate tooltip * remove maincontainer * CI errors' * Renderazing dynamic page * Avoid use network con ContractDetail * Avoid use network con ContractDetail again * Trying fix network error * Removing contract API * Removing Domain on apiBaseUrlPath * Using basePath based on the environment * Removing console * Using VERCEL_URL * Trying another order * Using URL_params instead of dynamic URL * Getting metadata when not is downloaded * Adding Redirection with uuid after create contract --------- Co-authored-by: Agustín Longoni <[email protected]> * Tables UI Improvements + New Documentation (#256) * add json metadata to actions * move contract table to homepage * add Last contract titte and network * improve no contracts message * move table to components * table refactor * fix errors * clean code * remove old documentation and add new external documentation * remove doc tests * refactor WIP Co-authored-by: Henry Palacios <[email protected]> * Donwload metadata on contracts table * Fix typo on useDonwloadSource * Improve the downloaded file name --------- Co-authored-by: Andre Neyra <[email protected]> Co-authored-by: Henry Palacios <[email protected]> Co-authored-by: Henry Palacios <[email protected]> * connection validations (#257) * Adding validatino when no connected * AutoFocus on editContractName * contract detail design + share functionality * fix imports * move contract-details to view * add edit contract name and download logic * fix build problem * fix deployed by address and edit button container * update contractDetail * fix edit name bug * fix tab padding * add action container * fix table head aligmnet * decrease tabs size --------- Co-authored-by: Henry Palacios <[email protected]> Co-authored-by: AndrN <[email protected]> Co-authored-by: Henry Palacios <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Create "Contracts" table
Add Share contract Modal