Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improperly disposed projects and only respond to selection changes for the project that the selection model belongs to #10

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

matthewhorridge
Copy link
Contributor

This pull request makes some changes to ensure that project objects, especially those that register listeners, are properly disposed of. This fixes a problem where if a project, ProjectA, was switch out for another project, ProjectB, in the same browser window calls to update the UI for both ProjectA and ProjectB would be made when any selection change was made.

@@ -69,19 +74,19 @@ public void setNodePropertiesChangedHandler(Consumer<TerminalNode> nodePropertie

@Override
public IsWidget getWidget(TerminalNode terminalNode) {
GWT.log("[PortletWidgetMapper] Getting widget for TerminalNode: " + terminalNode);
logger.info("logger.infoGetting widget for TerminalNode: " + terminalNode);
Copy link
Collaborator

@alexsilaghi alexsilaghi Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] I think we should replace the log.info with perhaps log.debug ? leave this kind of logs only for debugging purposes since it generates more traffic through the network.

@matthewhorridge matthewhorridge merged commit 8713c7d into master Jun 4, 2024
1 check passed
@matthewhorridge matthewhorridge deleted the fix-improperly-disposed-projects branch June 4, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants