wip added comment for reason for change for edit parents

protegeproject · May 27, 2024 · c915dbc · c915dbc
1 parent 4374137
commit c915dbc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/...ain/java/edu/stanford/bmir/protege/web/client/hierarchy/parents/EditParentsPresenter.java b/...ain/java/edu/stanford/bmir/protege/web/client/hierarchy/parents/EditParentsPresenter.java
@@ -10,6 +10,7 @@
 import edu.stanford.bmir.protege.web.shared.hierarchy.ChangeEntityParentsAction;
 import edu.stanford.bmir.protege.web.shared.hierarchy.GetHierarchyParentsAction;
 import edu.stanford.bmir.protege.web.shared.hierarchy.HierarchyId;
+import edu.stanford.bmir.protege.web.shared.issues.CreateEntityDiscussionThreadAction;
 import edu.stanford.bmir.protege.web.shared.project.ProjectId;
 import edu.stanford.bmir.protege.web.shared.renderer.GetEntityRenderingAction;
 import org.semanticweb.owlapi.model.EntityType;
@@ -84,10 +85,8 @@ public void start(@Nonnull OWLEntity entity) {
         dispatch.execute(GetEntityRenderingAction.create(projectId, entity),
                 result -> view.setOwlEntityData(result.getEntityData()));
 
-        hierarchyId.ifPresent(id -> {
-            dispatch.execute(GetHierarchyParentsAction.create(projectId, entity, id),
-                    result -> view.setEntityParents(result.getParents()));
-        });
+        hierarchyId.ifPresent(id -> dispatch.execute(GetHierarchyParentsAction.create(projectId, entity, id),
+                result -> view.setEntityParents(result.getParents())));
     }
 
     @Nonnull
@@ -104,6 +103,9 @@ private void handleHierarchyChange(OWLEntity entity, List<OWLPrimitiveData> pare
                 .map(owlPrimitiveData -> owlPrimitiveData.asEntity().get().asOWLClass())
                 .collect(toImmutableSet());
         dispatch.execute(ChangeEntityParentsAction.create(projectId, parentsSet, entity.asOWLClass(), view.getReasonForChange()),
-                changeEntityParentsResult -> {});
+                changeEntityParentsResult -> dispatch.execute(
+                        CreateEntityDiscussionThreadAction.create(projectId, entity, view.getReasonForChange()),
+                        threadActionResult -> {
+                        }));
     }
 }
diff --git a/...main/java/edu/stanford/bmir/protege/web/client/hierarchy/parents/EditParentsViewImpl.java b/...main/java/edu/stanford/bmir/protege/web/client/hierarchy/parents/EditParentsViewImpl.java
@@ -130,8 +130,6 @@ public String getReasonForChange() {
 
     @Override
     public List<OWLPrimitiveData> getNewParentList() {
-        return this.domains.getValue().orElseGet(() -> {
-            return new ArrayList<OWLPrimitiveData>();
-        });
+        return this.domains.getValue().orElseGet(ArrayList::new);
     }
 }