Update notebooks with settings file #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding settings to notebooks should be straightforward. The closed but unmerged PR can be referenced for guidance on how to generate a settings file and incorporate it within a notebook |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates notebooks with (optional) ModelScan settings file.
To create a configurable settings file use:
modelscan create-settings-file(creates amodelscan-settings.tomlfile in current directory).The location and name of a settings file can also be specified with
modelscan create-settings-file -l ../path-to/settings-file.tomlConfigurations:
A settings file would allow enabling/disabling particular scans such as
H5LambdaDetectScan, andPickleUnsafeOpScan.A settings file can also be configured to set particular severity level (CRITICAL, HIGH, MEDIUM, or LOW) for unsafe operators.
Reporting format for ModelScan results can also be specified in a settings file.