PyTorch Zipfile Check and Tests #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
swashko
commented
Jan 19, 2024
swashko
commented
- Adds a check to PyTorchUnsafeOpScan against being a zipfile, since PyTorch's newer format (after 1.6) saves as a zip that can be unzipped to get a pickle file, but if PyTorchUnsafeOpScan gets a zipfile, it will fail due to Magic Number mismatch
- Intended behavior for new format PyTorch files is to unzip and scan the pickle with PickleUnsafeOpScan
- Adds tests for safe old and new format PyTorch files and unsafe new format
- Updated Pytorch tests #18 to just need an old format unsafe file test, since our current PickleInject is not working with the old format
- Closes Invalid magic number for pytorch model scan #82
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.