Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Hugging Face Support #60

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Remove Hugging Face Support #60

merged 3 commits into from
Nov 28, 2023

Conversation

mehrinkiani
Copy link
Member

This PR removes the support for scanning Hugging Face models directly using -hf argument. Users can still scan Hugging Face models by first saving them on local disk and using the path option: modelscan -p path-to/model-file

Closes #58

@mehrinkiani mehrinkiani requested a review from a team November 21, 2023 22:09
@mehrinkiani mehrinkiani self-assigned this Nov 21, 2023
swashko
swashko approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@swashko swashko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehrinkiani mehrinkiani merged commit 572df37 into main Nov 28, 2023
8 checks passed
@mehrinkiani mehrinkiani deleted the 58-remove-hf branch November 28, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashko swashko swashko approved these changes

Assignees

@mehrinkiani mehrinkiani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Hugging Face as selectable model path
2 participants
@mehrinkiani @swashko